fix(pypi): reuse select dicts for constructing the env#3108
Merged
Conversation
aignas
force-pushed
the
fix.pep508_env
branch
6 times, most recently
from
July 21, 2025 01:53
0af9537 to
cca2bb0
Compare
Before this PR we would be constructing slightly different environments when the `env_marker_setting` is doing it in the analysis phase and when we are doing it in the repo phase due to how the defaults are handled. In this change we simply reuse the same select statements and add an extra helper that is allowing us to process that. Work towards bazel-contrib#2949 Prep for bazel-contrib#3058
rickeylev
approved these changes
Aug 11, 2025
rickeylev
enabled auto-merge
August 11, 2025 03:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR we would be constructing slightly different environments
when the
env_marker_settingis doing it in the analysis phase and whenwe are doing it in the repo phase due to how the defaults are handled.
In this change we simply reuse the same select statements and add an extra
helper that is allowing us to process that.
Work towards #2949
Prep for #3058